-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libcgroup: update to 2.0. #32231
libcgroup: update to 2.0. #32231
Conversation
pre_configure is not necessary, because you use a tarball with pregenerated configure script. The commit message body is not necessary. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert the changes on patches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the file has been reverted as in the original
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is wrong, GitHub still shows the change. Are you sure you reverted the changes?
srcpkgs/libcgroup/template
Outdated
checksum=aecc501a9ea6a97da0673585db5081df912ae607dec36d5f6f7ab14f69d48ab8 | ||
case "$XBPS_TARGET_MACHINE" in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add an empty line between checksum= and case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was not solved
sorry for the double comment
do you mean the block?
|
yes and you might be able to remove the hostmakedepends variable then |
without the pre_configure block it builds fine |
update libcgroup to version 2.0
sorry, I forgot about flex, we can drop automake and libtool, but have to leave flex there
Can you also fix the lint issue from CI?
|
srcpkgs/libcgroup/template
Outdated
distfiles="${SOURCEFORGE_SITE}/libcg/${pkgname}-${version}.tar.bz2" | ||
checksum=e4e38bdc7ef70645ce33740ddcca051248d56b53283c0dc6d404e17706f6fb51 | ||
homepage="https://github.com/libcgroup/libcgroup" | ||
distfiles="https://github.com/libcgroup/libcgroup/releases/download/v${version}/${pkgname}-${version}.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't use $pkgname please
@wibed are you still interested in continuing to work on this PR? |
@mt3 you just comitted literally when i was to to push my changes upstream |
@mt3 it seems the checksum should be updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please squash the commits to one
yes, that should fix the CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
squash the commits and it should be good to go
srcpkgs/libcgroup/template
Outdated
checksum=e4e38bdc7ef70645ce33740ddcca051248d56b53283c0dc6d404e17706f6fb51 | ||
license="LGPL-2.1-only" | ||
homepage="https://github.com/libcgroup/libcgroup" | ||
distfiles="https://github.com/libcgroup/libcgroup/releases/download/v${version}/libcgroup-${version}.tar.bz2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use tar.gz
This reverts commit 66ce3b42f27177cffac4dbd985eff07b51c91373.
it is getting late |
How are you trying to rebase and squash the commits? We have a lot of comments in PRs here explaining how to do it correctly, if you need the exact commands. |
i usually do a : but i have accidentally interleaved other commits, which makes it impossible to squash |
checksum bz2 corrected Revert "NO PUSH" This reverts commit 66ce3b42f27177cffac4dbd985eff07b51c91373. update to 2.0
ill reopen a new pr |
update libcgroup to version 2.0
General
Have the results of the proposed changes been tested?